Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24935 )
Change subject: experiment: replace squeasel with crow as webserver ...................................................................... Patch Set 1: (11 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/24935/1/be/src/util/webserver-test.cc File be/src/util/webserver-test.cc: http://gerrit.cloudera.org:8080/#/c/24935/1/be/src/util/webserver-test.cc@746 PS1, Line 746: // bug through: crow::utility::sanitize_filename() replaces a leading '/' with '_' to block line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24935/1/be/src/util/webserver.cc File be/src/util/webserver.cc: http://gerrit.cloudera.org:8080/#/c/24935/1/be/src/util/webserver.cc@200 PS1, Line 200: "(Advanced) Number of threads used to serve the debug webserver. Requests are handled " line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24935/1/be/src/util/webserver.cc@385 PS1, Line 385: /// Returns true if 'req' passed CSRF checks, otherwise fills in 'res' and returns false. line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24935/1/be/src/util/webserver.cc@623 PS1, Line 623: auto compressor_cleanup = MakeScopeExitTrigger([&compressor]() { compressor->Close(); }); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24935/1/be/src/util/webserver.cc@814 PS1, Line 814: return Status("--ssl_minimum_version=tlsv1.3 requires an OpenSSL build with TLS 1.3"); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/24935/1/be/src/util/webserver.cc@852 PS1, Line 852: LOG(WARNING) << "--webserver_authentication_domain is ignored: it was the HTTP Digest " line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24935/1/be/src/util/webserver.cc@857 PS1, Line 857: // If Kerberos has been configured, security::InitKerberosForServer() will already have line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24935/1/be/src/util/webserver.cc@858 PS1, Line 858: // been called, ensuring that the keytab path has been propagated into this environment line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24935/1/be/src/util/webserver.cc@861 PS1, Line 861: // If --spnego_keytab_file is not empty, use that instead of --keytab_file, to separate line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24935/1/be/src/util/webserver.cc@998 PS1, Line 998: // Crow streams the file from disk in 16KB chunks rather than buffering it. The '_unsafe' line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24935/1/be/src/util/webserver.cc@1025 PS1, Line 1025: // Take the query string from raw_url rather than offsetting by url.size(): NormalizeUri() line too long (92 > 90) -- To view, visit http://gerrit.cloudera.org:8080/24935 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0401456c79314fc51e89e192cd87f9a855e67163 Gerrit-Change-Number: 24935 Gerrit-PatchSet: 1 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 24 Sep 2026 15:19:22 +0000 Gerrit-HasComments: Yes
