Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24871 )
Change subject: IMPALA-15203: Add aggregate function support for UUID columns ...................................................................... Patch Set 4: Code-Review+1 (5 comments) Left a few small comments, otherwise LGTM! http://gerrit.cloudera.org:8080/#/c/24871/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24871/4//COMMIT_MSG@29 PS4, Line 29: Exclude UUID from codegen Could also mention that hash-table codegen is now turned on for UUID http://gerrit.cloudera.org:8080/#/c/24871/4/be/src/exec/aggregator.cc File be/src/exec/aggregator.cc: http://gerrit.cloudera.org:8080/#/c/24871/4/be/src/exec/aggregator.cc@450 PS4, Line 450: FIXED_UDA_INTERMEDIATE case nit: could also mention UUID http://gerrit.cloudera.org:8080/#/c/24871/4/fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java File fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java: http://gerrit.cloudera.org:8080/#/c/24871/4/fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java@969 PS4, Line 969: Type t = c.getType(); : return !t.isValid() || !t.isSupported() || t.isComplexOrVariantType() : || c.isHidden(); Or we could add UUID here. http://gerrit.cloudera.org:8080/#/c/24871/4/fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java File fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java: http://gerrit.cloudera.org:8080/#/c/24871/4/fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java@552 PS4, Line 552: AggIfFinalizeUuid This doesn't exist in the BE, we can remove this entry. http://gerrit.cloudera.org:8080/#/c/24871/4/tests/query_test/test_iceberg.py File tests/query_test/test_iceberg.py: http://gerrit.cloudera.org:8080/#/c/24871/4/tests/query_test/test_iceberg.py@103 PS4, Line 103: self.run_test_case('QueryTest/iceberg-uuid-aggregates', vector, : use_db=unique_database) Please run this with disable_codegen in [True, False]. -- To view, visit http://gerrit.cloudera.org:8080/24871 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2187495c8be5b95ecff3f458b6549916466e9c83 Gerrit-Change-Number: 24871 Gerrit-PatchSet: 4 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 24 Sep 2026 11:47:15 +0000 Gerrit-HasComments: Yes
