Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24940 )
Change subject: IMPALA-11917: Upgrade to GCC 15 and LLVM 22 ...................................................................... Patch Set 4: (26 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/24940/4/be/src/codegen/llvm-codegen-test.cc File be/src/codegen/llvm-codegen-test.cc: http://gerrit.cloudera.org:8080/#/c/24940/4/be/src/codegen/llvm-codegen-test.cc@625 PS4, Line 625: // Verify IR struct types: defined types are non-opaque; pointer-only types are opaque placeholders. line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/24940/4/be/src/exec/avro/hdfs-avro-scanner.cc File be/src/exec/avro/hdfs-avro-scanner.cc: http://gerrit.cloudera.org:8080/#/c/24940/4/be/src/exec/avro/hdfs-avro-scanner.cc@1094 PS4, Line 1094: builder->CreateStructGEP(tuple_type, tuple_val, slot_desc->llvm_field_idx(), "slot"); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/24940/4/be/src/exec/catalog-op-executor.cc File be/src/exec/catalog-op-executor.cc: http://gerrit.cloudera.org:8080/#/c/24940/4/be/src/exec/catalog-op-executor.cc@158 PS4, Line 158: &CatalogServiceClientWrapper::ResetMetadataWithRetry, request.reset_metadata_params, line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/24940/4/be/src/exec/exec-node.cc File be/src/exec/exec-node.cc: http://gerrit.cloudera.org:8080/#/c/24940/4/be/src/exec/exec-node.cc@679 PS4, Line 679: llvm::Value* eval_arg = builder.CreateLoad(codegen->ptr_type(), eval_arg_ptr, "eval"); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/24940/4/be/src/exec/filter-context.cc File be/src/exec/filter-context.cc: http://gerrit.cloudera.org:8080/#/c/24940/4/be/src/exec/filter-context.cc@221 PS4, Line 221: llvm::Value* expr_eval_arg = builder.CreateLoad(expr_eval_type, expr_eval_ptr, "expr_eval_arg"); line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/24940/4/be/src/exec/filter-context.cc@257 PS4, Line 257: llvm::Value* filter_ptr = builder.CreateStructGEP(filter_context_type, this_arg, 1, "filter_ptr"); line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/24940/4/be/src/exec/filter-context.cc@409 PS4, Line 409: builder.CreateStructGEP(filter_context_type, this_arg, 3, "local_bloom_filter_ptr"); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/24940/4/be/src/exec/filter-context.cc@416 PS4, Line 416: builder.CreateStructGEP(filter_context_type, this_arg, 4, "local_min_max_filter_ptr"); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/24940/4/be/src/exec/hash-table.cc File be/src/exec/hash-table.cc: http://gerrit.cloudera.org:8080/#/c/24940/4/be/src/exec/hash-table.cc@943 PS4, Line 943: codegen->i8_type(), expr_values_null, codegen->GetI32Constant(i), "null_byte_loc"); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24940/4/be/src/exprs/kudu-partition-expr.cc File be/src/exprs/kudu-partition-expr.cc: http://gerrit.cloudera.org:8080/#/c/24940/4/be/src/exprs/kudu-partition-expr.cc@145 PS4, Line 145: *kudu_row_ptr = builder->CreateLoad(kudu_row_ptr_type, kudu_row_ptr_ptr, "kudu_row_ptr"); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24940/4/be/src/exprs/scalar-fn-call.cc File be/src/exprs/scalar-fn-call.cc: http://gerrit.cloudera.org:8080/#/c/24940/4/be/src/exprs/scalar-fn-call.cc@310 PS4, Line 310: llvm::Function* get_fn_ctx_fn = codegen->GetFunction(IRFunction::GET_FUNCTION_CTX, false); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/24940/4/be/src/exprs/slot-ref.cc File be/src/exprs/slot-ref.cc: http://gerrit.cloudera.org:8080/#/c/24940/4/be/src/exprs/slot-ref.cc@391 PS4, Line 391: res.SetSimpleVal(builder->CreateLoad(codegen->GetSlotType(type_), val_ptr, type_, "val")); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/24940/4/be/src/rpc/thrift-server-test.cc File be/src/rpc/thrift-server-test.cc: http://gerrit.cloudera.org:8080/#/c/24940/4/be/src/rpc/thrift-server-test.cc@756 PS4, Line 756: EXPECT_THROW({ssl_client.iface()->RegisterSubscriber(resp, TRegisterSubscriberRequest()); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24940/4/be/src/rpc/thrift-server-test.cc@761 PS4, Line 761: EXPECT_THROW({ssl_client.iface()->RegisterSubscriber(resp, TRegisterSubscriberRequest()); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24940/4/be/src/runtime/buffered-tuple-stream.cc File be/src/runtime/buffered-tuple-stream.cc: http://gerrit.cloudera.org:8080/#/c/24940/4/be/src/runtime/buffered-tuple-stream.cc@1057 PS4, Line 1057: llvm::Value* data_start = builder.CreateLoad(codegen->ptr_type(), data_arg, "data_start"); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/24940/4/be/src/runtime/descriptors.cc File be/src/runtime/descriptors.cc: http://gerrit.cloudera.org:8080/#/c/24940/4/be/src/runtime/descriptors.cc@1321 PS4, Line 1321: llvm::Value* ptr_addr = builder->CreateStructGEP(coll_value_type, str_or_coll_value_addr, line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/24940/4/be/src/runtime/descriptors.cc@1337 PS4, Line 1337: llvm::Value* len_addr = builder->CreateStructGEP(coll_value_type, str_or_coll_value_addr, line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/24940/4/be/src/runtime/descriptors.cc@1447 PS4, Line 1447: llvm::Value* item_index = builder->CreateLoad(codegen->i32_type(), item_index_addr, "item_index"); line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/24940/4/be/src/runtime/descriptors.cc@1552 PS4, Line 1552: child_str_or_coll_value_slot, type_.IsVarLenStringType(), "child_str_or_coll_value_ptr"); line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/24940/4/be/src/runtime/descriptors.cc@1554 PS4, Line 1554: child_str_or_coll_value_slot, type_.IsVarLenStringType(), "child_str_or_coll_value_len"); line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/24940/4/be/src/runtime/tuple.cc File be/src/runtime/tuple.cc: http://gerrit.cloudera.org:8080/#/c/24940/4/be/src/runtime/tuple.cc@596 PS4, Line 596: llvm::Value* offset_start = builder.CreateLoad(codegen->i32_type(), offset, "offset_start"); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/24940/4/be/src/statestore/statestore-subscriber-client-wrapper.h File be/src/statestore/statestore-subscriber-client-wrapper.h: http://gerrit.cloudera.org:8080/#/c/24940/4/be/src/statestore/statestore-subscriber-client-wrapper.h@44 PS4, Line 44: void UpdateStateWithRetry(TUpdateStateResponse& _return, const TUpdateStateRequest& params, line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/24940/4/be/src/statestore/statestore.cc File be/src/statestore/statestore.cc: http://gerrit.cloudera.org:8080/#/c/24940/4/be/src/statestore/statestore.cc@1107 PS4, Line 1107: &StatestoreSubscriberClientWrapper::UpdateStateWithRetry, update_state_request, &response)); line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/24940/4/be/src/statestore/statestore.cc@1309 PS4, Line 1309: client.DoRpc(&StatestoreSubscriberClientWrapper::HeartbeatWithRetry, request, &response)); line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/24940/4/be/src/statestore/statestore.cc@1606 PS4, Line 1606: &StatestoreSubscriberClientWrapper::UpdateCatalogdWithRetry, request, &response); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/24940/4/be/src/statestore/statestore.cc@1740 PS4, Line 1740: status = client.DoRpc(&StatestoreSubscriberClientWrapper::UpdateStatestoredRoleWithRetry, line too long (97 > 90) -- To view, visit http://gerrit.cloudera.org:8080/24940 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7dda730fa98ebe3825969265627a560b0c3095f9 Gerrit-Change-Number: 24940 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 25 Sep 2026 18:46:13 +0000 Gerrit-HasComments: Yes
