Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24918 )
Change subject: IMPALA-14148: Update Protobuf to 3.21.9 ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/24918/5/source/protobuf/protobuf-3.21.9-patches/0001-Add-AddressSanitizer-annotations-from-LLVM-asan_inte.patch File source/protobuf/protobuf-3.21.9-patches/0001-Add-AddressSanitizer-annotations-from-LLVM-asan_inte.patch: http://gerrit.cloudera.org:8080/#/c/24918/5/source/protobuf/protobuf-3.21.9-patches/0001-Add-AddressSanitizer-annotations-from-LLVM-asan_inte.patch@26 PS5, Line 26: +#define ASAN_UNPOISON_MEMORY_REGION(addr, size) \ This is no longer sufficient. I might hold off on this until the LLVM upgrade is complete and see if we can remove the clang-specific build. -- To view, visit http://gerrit.cloudera.org:8080/24918 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7d710d88a03c96c9e49d75dcb11c7cc438c3da79 Gerrit-Change-Number: 24918 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Fri, 25 Sep 2026 21:00:14 +0000 Gerrit-HasComments: Yes
