Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24949 )
Change subject: IMPALA-15423: Fix non-ASCII strings in Iceberg metadata tables ...................................................................... Patch Set 2: (4 comments) Thanks for the comments! http://gerrit.cloudera.org:8080/#/c/24949/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24949/1//COMMIT_MSG@14 PS1, Line 14: NUL > Have we tested this case? Good catch, added test http://gerrit.cloudera.org:8080/#/c/24949/1/be/src/util/jni-util.h File be/src/util/jni-util.h: http://gerrit.cloudera.org:8080/#/c/24949/1/be/src/util/jni-util.h@112 PS1, Line 112: modified UTF > I think we should update this to modified utf-8. Done http://gerrit.cloudera.org:8080/#/c/24949/1/be/src/util/jni-util.h@137 PS1, Line 137: does not > Unrelated but should this be "does not"? Done http://gerrit.cloudera.org:8080/#/c/24949/1/fe/src/main/java/org/apache/impala/util/IcebergMetadataScanner.java File fe/src/main/java/org/apache/impala/util/IcebergMetadataScanner.java: http://gerrit.cloudera.org:8080/#/c/24949/1/fe/src/main/java/org/apache/impala/util/IcebergMetadataScanner.java@140 PS1, Line 140: /** > Unrelated nit: Double blank lines. Done -- To view, visit http://gerrit.cloudera.org:8080/24949 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I862e327e4b7b93dfabb660d88a21e04ee7b03cd5 Gerrit-Change-Number: 24949 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 28 Sep 2026 09:19:52 +0000 Gerrit-HasComments: Yes
