Xuebin Su has posted comments on this change. ( http://gerrit.cloudera.org:8080/24338 )
Change subject: IMPALA-14882: part2: Convert impala tuple batch to arrow record batch ...................................................................... Patch Set 8: Code-Review+1 (2 comments) > Patch Set 8: > > (1 comment) Thanks! http://gerrit.cloudera.org:8080/#/c/24338/7/be/src/exec/arrow-converter.cc File be/src/exec/arrow-converter.cc: http://gerrit.cloudera.org:8080/#/c/24338/7/be/src/exec/arrow-converter.cc@731 PS7, Line 731: } > Done Done http://gerrit.cloudera.org:8080/#/c/24338/8/be/src/exec/arrow-converter.cc File be/src/exec/arrow-converter.cc: http://gerrit.cloudera.org:8080/#/c/24338/8/be/src/exec/arrow-converter.cc@749 PS8, Line 749: return row_batch->GetRow(row_idx)->GetTuple(0)->IsNull(null_indicator_offset); It seems that GetTuple() might return a nullptr. Since the function is only used in the tests, I think it is OK to fix this issue in another patch later. -- To view, visit http://gerrit.cloudera.org:8080/24338 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37be9989ad6d7016ae1223bc131cb3f6a1af1bb2 Gerrit-Change-Number: 24338 Gerrit-PatchSet: 8 Gerrit-Owner: Balazs Hevele <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Tue, 29 Sep 2026 07:22:29 +0000 Gerrit-HasComments: Yes
