Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24972 )
Change subject: IMPALA-14177: Fix test_client_fetch_time_stats(_incomplete) on ARM ...................................................................... IMPALA-14177: Fix test_client_fetch_time_stats(_incomplete) on ARM On systems where Impala uses CLOCK_MONOTONIC_COARSE the tests nearly always failed since enabling long polling by default (IMPALA-14686): the first "inactive period" took less than 1ms, which was counted as 0 with a ms precision clock, leading to ignoring the first request in client_wait_time_stats_. The coarse clock was used in the clocksource != "tsc" case, which corresponds to ARM VMs in case of current Impala tests, but is not specific to ARM in general. Changes: - always update client_wait_time_stats_ after the timer is started (it is possible to get a request before it starts, which is intentionally ignored in the counter: IMPALA-10180) - added sleeps to tests to be more deterministic - fix parsing logic in the tests (get_time_summary_stats_counter) which parsed Sum's value as Max due to greedy regexp - close hs2 connection in tests when it fails - earlier the test failures also led to TestValidateMetrics.test_metrics_are_zero errors Change-Id: I7a3b6d72109110c078abdae7483fb9f4c5df7f07 Assisted-by: Claude Opus 5.0 Reviewed-on: http://gerrit.cloudera.org:8080/24972 Reviewed-by: Arnab Karmakar <[email protected]> Reviewed-by: Michael Smith <[email protected]> Reviewed-by: Joe McDonnell <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/service/client-request-state.cc M be/src/service/client-request-state.h M tests/infra/test_utils.py M tests/query_test/test_fetch.py M tests/util/parse_util.py 5 files changed, 76 insertions(+), 62 deletions(-) Approvals: Arnab Karmakar: Looks good to me, but someone else must approve Michael Smith: Looks good to me, approved Joe McDonnell: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/24972 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I7a3b6d72109110c078abdae7483fb9f4c5df7f07 Gerrit-Change-Number: 24972 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]>
