Hello Zoltan Borok-Nagy, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24968
to look at the new patch set (#5).
Change subject: IMPALA-15447: forward Iceberg scan reports to a side reporter
......................................................................
IMPALA-15447: forward Iceberg scan reports to a side reporter
Adds an optional, operator-configured Iceberg MetricsReporter that
runs alongside the existing InMemoryMetricsReporter, so a deployment
can forward scan reports (files/bytes/delete-file counts, pushed-down
filter, snapshot id) to its own metrics sink without disturbing the
query profile.
The side reporter is loaded once per JVM via the Iceberg SPI
(CatalogUtil.loadMetricsReporter), selected by the standard
'metrics-reporter-impl' property; when unset, behavior is unchanged
and only the InMemory reporter is used. A configured reporter must
not block: it is invoked on the planning thread.
Each scan report is stamped with the query's own id under namespaced
metadata keys (impala.query-id, impala.engine-name) so a query's
reports can be correlated downstream. Keys are namespaced to avoid
colliding with Iceberg read options.
Testing:
- Added IcebergScanReportTest: asserts impala.query-id and
impala.engine-name surface in the InMemoryMetricsReporter's
ScanReport metadata (run: mvn test -Dtest=IcebergScanReportTest).
- Ran gerrit-auto-critic (--dryrun): clean.
Change-Id: I2a290d79ec467a663af32efcce4bcdfebd7d9287
Assisted-by: Claude Opus 4.8 (Claude Code)
Co-Authored-By: Claude Opus 4.8 <[email protected]>
---
M fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java
M fe/src/main/java/org/apache/impala/util/IcebergUtil.java
A fe/src/test/java/org/apache/impala/util/IcebergScanReportTest.java
3 files changed, 246 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/24968/5
--
To view, visit http://gerrit.cloudera.org:8080/24968
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2a290d79ec467a663af32efcce4bcdfebd7d9287
Gerrit-Change-Number: 24968
Gerrit-PatchSet: 5
Gerrit-Owner: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
