Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/24913 )
Change subject: IMPALA-15394: Add missing scan properties to the HBO scan key ...................................................................... Patch Set 5: (3 comments) Added test_partition_key_scan_cardinality in PS6. On a cluster without this patch, the regular scan after a partition key scan gets cardinality=4 (from HBO) instead of 1.22K. http://gerrit.cloudera.org:8080/#/c/24913/5/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: http://gerrit.cloudera.org:8080/#/c/24913/5/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@1941 PS5, Line 1941: // key scan one row per scan range, not the table's rows, while their input stats > nit: add "returns" Done http://gerrit.cloudera.org:8080/#/c/24913/5/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@1943 PS5, Line 1943: // the files, and without numRows its runs are matched by the catalog version alone. > nit: remove this? It's a bit confusing. We also match total file bytes and Removed it here and in the commit message. http://gerrit.cloudera.org:8080/#/c/24913/5/tests/query_test/test_hbo.py File tests/query_test/test_hbo.py: http://gerrit.cloudera.org:8080/#/c/24913/5/tests/query_test/test_hbo.py@247 PS5, Line 247: # expected cardinality doesn't depend on the size of the data files. > nit: "Use a parquet table with stats." Done -- To view, visit http://gerrit.cloudera.org:8080/24913 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I03183aa998f90bf834dba4ce9ad2f2e57fef1140 Gerrit-Change-Number: 24913 Gerrit-PatchSet: 5 Gerrit-Owner: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Wed, 30 Sep 2026 09:43:09 +0000 Gerrit-HasComments: Yes
