Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/24940 )
Change subject: IMPALA-11917: Upgrade to GCC 15 and LLVM 22 ...................................................................... Patch Set 8: (3 comments) I tested this patch with the experimental all-build-options job running on Ubuntu 22.04 (see https://jenkins.impala.io/view/Ubuntu%2022/job/all-build-options-ub2204/14/ ), and I'm happy to report that it fixes IMPALA-15008 (ASAN failures in various tools during all-build-options build) as well. This gets us one step closer to moving the precommit workflow to Ubuntu 22.04 http://gerrit.cloudera.org:8080/#/c/24940/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24940/7//COMMIT_MSG@38 PS7, Line 38: s nit: capitalize please :) http://gerrit.cloudera.org:8080/#/c/24940/7//COMMIT_MSG@40 PS7, Line 40: i nit: typo http://gerrit.cloudera.org:8080/#/c/24940/8/be/src/udf/udf.h File be/src/udf/udf.h: http://gerrit.cloudera.org:8080/#/c/24940/8/be/src/udf/udf.h@735 PS8, Line 735: // val16 is __int128_t, whose natural alignment is 16 bytes, but instances of this : // struct routinely live in memory that's only 8-byte aligned (tuple slots, UDA : // intermediate buffers from FunctionContext::Allocate(), etc). "packed" tells the : // compiler not to assume 16-byte alignment when generating loads/stores/copies for : // this type, avoiding SIGSEGV from misaligned SSE instructions (e.g. movaps). : struct __attribute__((packed)) DecimalVal : public impala_udf::AnyVal { > What is the effect of this on existing UDFs? I assume recompilation is need Yes, if that's the case, we'll need to track it carefully: - mention it in the commit message - point it out in the release notes We know of several users who build solutions around custom UDFs; they should be made aware. -- To view, visit http://gerrit.cloudera.org:8080/24940 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7dda730fa98ebe3825969265627a560b0c3095f9 Gerrit-Change-Number: 24940 Gerrit-PatchSet: 8 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Wed, 30 Sep 2026 09:19:29 +0000 Gerrit-HasComments: Yes
