Daniel Vanko has posted comments on this change. ( http://gerrit.cloudera.org:8080/24636 )
Change subject: IMPALA-8523: Migrate hdfsOpen to builder-based openFile API ...................................................................... Patch Set 8: (2 comments) > Patch Set 7: > > (2 comments) > > Please run exhaustive tests on S3 and Ozone as well Ran them and no new failures compared to master. (will do followup tickets for the failed tests) I had to rebase this patchset to be able to build, but the only change is using GetFileInfo instead. http://gerrit.cloudera.org:8080/#/c/24636/7/be/src/exec/orc/hdfs-orc-scanner.cc File be/src/exec/orc/hdfs-orc-scanner.cc: http://gerrit.cloudera.org:8080/#/c/24636/7/be/src/exec/orc/hdfs-orc-scanner.cc@158 PS7, Line 158: metadata_range->GetFileInfo(), : length, offset, partition_id, split_range->disk_id(), expected_local, : BufferOpts::ReadInto(reinterpret_cast<uint8_t*>(buf), length, cache_options)); : unique_ptr<BufferDescriptor> io_buffer; : Status status; : { : SCOPED_TIMER2(scanner_->state_->total_storage_wait_timer(), : scanner_->scan_node_->scanner_io_wait_time()); > Could we use metadata_range->GetFileInfo? Yes, I checked and they're the same. http://gerrit.cloudera.org:8080/#/c/24636/7/be/src/exec/orc/hdfs-orc-scanner.cc@263 PS7, Line 263: context_->AddAndStartStream(scan_range, range.io_reservation, &range.stream_)); : } : return Status::OK(); : } : : Status HdfsOrcScanner::ColumnRange::read(void* buf, uint64_t length, uint64_t offset) { : if (offset + length > offset_ + length_) { > Similarly to above: Done -- To view, visit http://gerrit.cloudera.org:8080/24636 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I46d810b19fe7d4859e3c2bcd7568b61fe73408c1 Gerrit-Change-Number: 24636 Gerrit-PatchSet: 8 Gerrit-Owner: Daniel Vanko <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 30 Sep 2026 12:37:00 +0000 Gerrit-HasComments: Yes
