Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/24882 )
Change subject: IMPALA-15141 (part 1): Keep codegen enabled for queries on VARIANT ...................................................................... Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/24882/1/be/src/exec/avro/hdfs-avro-scanner.cc File be/src/exec/avro/hdfs-avro-scanner.cc: http://gerrit.cloudera.org:8080/#/c/24882/1/be/src/exec/avro/hdfs-avro-scanner.cc@807 PS1, Line 807: // VARIANT cannot be read from Avro and writing VARIANT slots is not codegen'd. Fall As far as I know we should never reach this, there's no way to have a VARIANT in an AVRO file, therefore this should be gated somewhere else -- To view, visit http://gerrit.cloudera.org:8080/24882 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6e3c59cc41bab7421e0dd450e08944ffc3889241 Gerrit-Change-Number: 24882 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Thu, 01 Oct 2026 12:26:40 +0000 Gerrit-HasComments: Yes
