Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/24881 )
Change subject: IMPALA-15371: Support IS [NOT] NULL on VARIANT columns ...................................................................... Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/24881/2/fe/src/main/java/org/apache/impala/analysis/IsNullPredicate.java File fe/src/main/java/org/apache/impala/analysis/IsNullPredicate.java: http://gerrit.cloudera.org:8080/#/c/24881/2/fe/src/main/java/org/apache/impala/analysis/IsNullPredicate.java@66 PS2, Line 66: List<Type> types = new ArrayList<>(Type.getSupportedTypes()); Isn't it better to add it ad Type.java? -- To view, visit http://gerrit.cloudera.org:8080/24881 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id0b17821f6c8a988abf93494b7dbeb8f6f7db216 Gerrit-Change-Number: 24881 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Thu, 01 Oct 2026 12:29:58 +0000 Gerrit-HasComments: Yes
