Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/23848 )
Change subject: IMPALA-14942: [tools] Impala devcontainer ...................................................................... Patch Set 54: (4 comments) Thanks for working on this! Asked Opus 5.5 to review and commented what I thought important. http://gerrit.cloudera.org:8080/#/c/23848/54/.devcontainer-build/devcontainer.json File .devcontainer-build/devcontainer.json: http://gerrit.cloudera.org:8080/#/c/23848/54/.devcontainer-build/devcontainer.json@53 PS54, Line 53: "ghcr.io/devcontainers-extra/features/vscode-server:1": {} Is it needed? The Dev Containers extension installs its own server in ~/.vscode-server when it attaches, and nothing starts code-server. Its license also doesn't allow redistribution. http://gerrit.cloudera.org:8080/#/c/23848/54/.devcontainer/README.md File .devcontainer/README.md: http://gerrit.cloudera.org:8080/#/c/23848/54/.devcontainer/README.md@2 PS54, Line 2: nit: it would helpful to add a short Requirements note http://gerrit.cloudera.org:8080/#/c/23848/54/.devcontainer/devcontainer.json File .devcontainer/devcontainer.json: http://gerrit.cloudera.org:8080/#/c/23848/54/.devcontainer/devcontainer.json@23 PS54, Line 23: "workspaceMount": "type=volume,target=/home/impdev/impala", Since the volume is anonymous, Rebuild Container creates a new container with a new volume copied from the image. Could we name the volume, e.g. `source=impala-dev-${devcontainerId},target=/home/impdev/impala,type=volume`? It is still seeded from the image on first use, and devcontainerId is stable across rebuilds. http://gerrit.cloudera.org:8080/#/c/23848/54/.devcontainer/set-tz-locale.sh File .devcontainer/set-tz-locale.sh: http://gerrit.cloudera.org:8080/#/c/23848/54/.devcontainer/set-tz-locale.sh@27 PS54, Line 27: Could add "-f noninteractive" (sudo drops DEBIAN_FRONTEND=noninteractive) -- To view, visit http://gerrit.cloudera.org:8080/23848 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6aa834494003619fcdfbd98f3bfc7c74d3e1554c Gerrit-Change-Number: 23848 Gerrit-PatchSet: 54 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Gowthami Bisati <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 01 Oct 2026 13:42:20 +0000 Gerrit-HasComments: Yes
