Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24994 )
Change subject: IMPALA-13591: Fix NPE when dropping column used in old partition spec ...................................................................... Patch Set 1: Code-Review+1 (1 comment) LGTM, but we could add a few more tests. http://gerrit.cloudera.org:8080/#/c/24994/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-alter-v2.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-alter-v2.test: http://gerrit.cloudera.org:8080/#/c/24994/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-alter-v2.test@516 PS1, Line 516: alter table ice_drop_old_part_col drop column p; I think we should also add some time-travel/metadata queries. -- To view, visit http://gerrit.cloudera.org:8080/24994 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie5f1439b31d7f460008760909306607018ac094f Gerrit-Change-Number: 24994 Gerrit-PatchSet: 1 Gerrit-Owner: Nandor Kollar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 01 Oct 2026 15:29:21 +0000 Gerrit-HasComments: Yes
