Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24989 )
Change subject: IMPALA-14778: Fix Close() crashes in Iceberg metadata and Paimon scans ...................................................................... Patch Set 3: (3 comments) Thanks for the comments! http://gerrit.cloudera.org:8080/#/c/24989/1/be/src/exec/iceberg-metadata/iceberg-metadata-scanner.h File be/src/exec/iceberg-metadata/iceberg-metadata-scanner.h: http://gerrit.cloudera.org:8080/#/c/24989/1/be/src/exec/iceberg-metadata/iceberg-metadata-scanner.h@82 PS1, Line 82: jbyteArray* result) WARN_UNUSED_RESULT; > What about jtable_? Good catch, done. http://gerrit.cloudera.org:8080/#/c/24989/1/be/src/exec/iceberg-metadata/iceberg-metadata-scanner.cc File be/src/exec/iceberg-metadata/iceberg-metadata-scanner.cc: http://gerrit.cloudera.org:8080/#/c/24989/1/be/src/exec/iceberg-metadata/iceberg-metadata-scanner.cc@262 PS1, Line 262: Status IcebergMetadataScanner::ConvertJavaCharSequenceToUtf8ByteArray(JNIEnv* env, > Isn't jtable_ a leaked global ref? We could delete it here, too. Done. http://gerrit.cloudera.org:8080/#/c/24989/1/fe/src/main/java/org/apache/impala/util/IcebergMetadataScanner.java File fe/src/main/java/org/apache/impala/util/IcebergMetadataScanner.java: http://gerrit.cloudera.org:8080/#/c/24989/1/fe/src/main/java/org/apache/impala/util/IcebergMetadataScanner.java@67 PS1, Line 67: final private String metadataTableName_; : : // Persist the file scan task iterator so we can continue after a RowBatch is full : private CloseableIterator<FileScanTask> fileScanTaskIterator_; : > Both CloseableIterators wrap Iceberg manifest/Avro readers and are never cl Done, added close() (the class is AutoCloseable now) and C++ Close() calls it. Also closing the rows iterator of each task when moving to the next one: for ENTRIES, ALL_ENTRIES and ALL_MANIFESTS the manifest reader was not closed even after reading all rows. -- To view, visit http://gerrit.cloudera.org:8080/24989 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0519035ecdca966bdc1a26147a157dc62bad2d8f Gerrit-Change-Number: 24989 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 02 Oct 2026 18:22:57 +0000 Gerrit-HasComments: Yes
