Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24852 )
Change subject: IMPALA-15358: Cap Kudu DML writers to partition count ...................................................................... Patch Set 13: (4 comments) http://gerrit.cloudera.org:8080/#/c/24852/12/common/thrift/ImpalaService.thrift File common/thrift/ImpalaService.thrift: http://gerrit.cloudera.org:8080/#/c/24852/12/common/thrift/ImpalaService.thrift@565 PS12, Line 565: inserts > nit: doesn't this apply to Kudu's upserts as well? Done http://gerrit.cloudera.org:8080/#/c/24852/12/fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java File fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java: http://gerrit.cloudera.org:8080/#/c/24852/12/fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java@280 PS12, Line 280: maxFsWriters > nit: given it's now applicable to Kudu, maybe 'maxWriters' would be a bette I'm going to keep it maxFsWriters since the query option is max_fs_writers. http://gerrit.cloudera.org:8080/#/c/24852/12/fe/src/main/java/org/apache/impala/planner/KuduTableSink.java File fe/src/main/java/org/apache/impala/planner/KuduTableSink.java: http://gerrit.cloudera.org:8080/#/c/24852/12/fe/src/main/java/org/apache/impala/planner/KuduTableSink.java@114 PS12, Line 114: maxKuduSinks_ > 0 > nit: why not to use hasInstanceLimit() here? Done http://gerrit.cloudera.org:8080/#/c/24852/12/fe/src/main/java/org/apache/impala/planner/KuduTableSink.java@124 PS12, Line 124: maxKuduSinks_ > 0 > nit: ditto -- why not to use hasInstanceLimit() here as well? Done -- To view, visit http://gerrit.cloudera.org:8080/24852 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia3644fb245ceac72e91ed70c8c0392f65df75fde Gerrit-Change-Number: 24852 Gerrit-PatchSet: 13 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 02 Oct 2026 20:18:15 +0000 Gerrit-HasComments: Yes
