Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24422 )
Change subject: IMPALA-15081: Add ISO timestamp filters ...................................................................... Patch Set 10: (4 comments) http://gerrit.cloudera.org:8080/#/c/24422/10//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24422/10//COMMIT_MSG@7 PS10, Line 7: IMPALA-15081: Add ISO timestamp filters > Since only the extended format is accepted I think mentioning something lik I have another issue with the commit message: it doesn't mention profile tool. I would prefer something like "Add text timestamp filter in impala-profile-tool" http://gerrit.cloudera.org:8080/#/c/24422/10//COMMIT_MSG@13 PS10, Line 13: Add --min_time and --max_time as timezone-aware ISO-8601 : alternatives. The new flags are converted to the same Unix epoch : millisecond bounds used by the existing filtering path, while rejecting : mixed use with the epoch millisecond flags. Can you add some examples of what is accepted? For example are named timezones handled, or only offsets? http://gerrit.cloudera.org:8080/#/c/24422/10//COMMIT_MSG@18 PS10, Line 18: New flags rather than a second accepted form on the existing ones. The nit: the paragraph is a bit verbose IMO I like the new names simply because they are shorter :) http://gerrit.cloudera.org:8080/#/c/24422/10/be/src/util/impala-profile-tool.cc File be/src/util/impala-profile-tool.cc: http://gerrit.cloudera.org:8080/#/c/24422/10/be/src/util/impala-profile-tool.cc@652 PS10, Line 652: ParseTimezoneAwareTime Isn't there a lib that does all this from us? AFAIK std::chrono can parse these from c++20 only, but Impala has access to both boost and abseil. Can't absl::ParseTime do this for us? -- To view, visit http://gerrit.cloudera.org:8080/24422 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2c43e7535db48518b7d9dd0cbb87398e639c3b72 Gerrit-Change-Number: 24422 Gerrit-PatchSet: 10 Gerrit-Owner: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 05 Oct 2026 06:29:29 +0000 Gerrit-HasComments: Yes
