Arnab Karmakar has posted comments on this change. ( http://gerrit.cloudera.org:8080/24536 )
Change subject: IMPALA-15162: Add GEOMETRY column support for Iceberg and Parquet ...................................................................... Patch Set 19: (3 comments) http://gerrit.cloudera.org:8080/#/c/24536/19//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24536/19//COMMIT_MSG@26 PS19, Line 26: AnalyzesContext nit: AnalysisContext http://gerrit.cloudera.org:8080/#/c/24536/19//COMMIT_MSG@27 PS19, Line 27: UPDATE+MERGE We could also mention OPTIMIZE. http://gerrit.cloudera.org:8080/#/c/24536/19/tests/query_test/test_geospatial_functions.py File tests/query_test/test_geospatial_functions.py: http://gerrit.cloudera.org:8080/#/c/24536/19/tests/query_test/test_geospatial_functions.py@156 PS19, Line 156: try: : self.run_stmt_in_hive( : "SELECT * FROM {0}.ice_geom_hive_test".format(unique_database)) : assert False, "Expected Hive query to fail on geometry/v3 table" : except Exception as e: : # Hive may reject due to unsupported format version 3 or unsupported geometry type. : assert "GEOMETRY type is not supported)" in str(e), \ : "Unexpected error from Hive: " + str(e) An unexpected success would fail with a misleading message "Unexpected error from Hive". We could use something like: try: self.run_stmt_in_hive() except Exception as e: assert else: assert False -- To view, visit http://gerrit.cloudera.org:8080/24536 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I32d8c12a6b71708646fbfc06a6dd8f7aaf4f5e6b Gerrit-Change-Number: 24536 Gerrit-PatchSet: 19 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Comment-Date: Mon, 05 Oct 2026 09:47:58 +0000 Gerrit-HasComments: Yes
