Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/25002 )
Change subject: IMPALA-15059: Use HBO stats for Calcite filters ...................................................................... Patch Set 1: (1 comment) Hmmm...I'm having trouble accessing the parent, https://gerrit.cloudera.org/#/c/25001/ Can you resubmit that one? http://gerrit.cloudera.org:8080/#/c/25002/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdRowCount.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdRowCount.java: http://gerrit.cloudera.org:8080/#/c/25002/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdRowCount.java@75 PS1, Line 75: RelNode scanInput = RelUtil.unwrapRelNode(input); Can we put all (or most) of this new code in a separate method. I think it's easier to read if the top level "getRowCount" method stays small-ish and contains mostly top level-ish operations. -- To view, visit http://gerrit.cloudera.org:8080/25002 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9270a5f94d42a4ad20d3337819b46467e83a3bf7 Gerrit-Change-Number: 25002 Gerrit-PatchSet: 1 Gerrit-Owner: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Mon, 05 Oct 2026 18:14:18 +0000 Gerrit-HasComments: Yes
