Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24472 )

Change subject: IMPALA-12232: Validate JWT aud/iss claims
......................................................................


Patch Set 13:

(5 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/24472/13/fe/src/test/java/org/apache/impala/customcluster/JwtHttpTest.java
File fe/src/test/java/org/apache/impala/customcluster/JwtHttpTest.java:

http://gerrit.cloudera.org:8080/#/c/24472/13/fe/src/test/java/org/apache/impala/customcluster/JwtHttpTest.java@256
PS13, Line 256:     THttpClientWithHeaders transport = new 
THttpClientWithHeaders("http://localhost:28000";);
line too long (92 > 90)


http://gerrit.cloudera.org:8080/#/c/24472/13/fe/src/test/java/org/apache/impala/customcluster/JwtHttpTest.java@335
PS13, Line 335:     THttpClientWithHeaders transport = new 
THttpClientWithHeaders("http://localhost:28000";);
line too long (92 > 90)


http://gerrit.cloudera.org:8080/#/c/24472/13/fe/src/test/java/org/apache/impala/customcluster/JwtHttpTest.java@367
PS13, Line 367:     THttpClientWithHeaders transport = new 
THttpClientWithHeaders("http://localhost:28000";);
line too long (92 > 90)


http://gerrit.cloudera.org:8080/#/c/24472/13/fe/src/test/java/org/apache/impala/customcluster/JwtHttpTest.java@403
PS13, Line 403:     THttpClientWithHeaders transport = new 
THttpClientWithHeaders("http://localhost:28000";);
line too long (92 > 90)


http://gerrit.cloudera.org:8080/#/c/24472/13/fe/src/test/java/org/apache/impala/customcluster/JwtHttpTest.java@442
PS13, Line 442:     THttpClientWithHeaders transport = new 
THttpClientWithHeaders("http://localhost:28000";);
line too long (92 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/24472
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a00b126359f2bc7e2f73d894cebc2b9014c7375
Gerrit-Change-Number: 24472
Gerrit-PatchSet: 13
Gerrit-Owner: Anubhav Jindal <[email protected]>
Gerrit-Reviewer: Abhishek Rawat <[email protected]>
Gerrit-Reviewer: Anonymous Coward (934)
Gerrit-Reviewer: Anubhav Jindal <[email protected]>
Gerrit-Reviewer: Gokul Kolady <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Reviewer: Yida Wu <[email protected]>
Gerrit-Comment-Date: Mon, 05 Oct 2026 21:19:00 +0000
Gerrit-HasComments: Yes

Reply via email to