Hello Steve Carlin, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/25004
to look at the new patch set (#3).
Change subject: IMPALA-15467: Fix Calcite IF DECIMAL return type
......................................................................
IMPALA-15467: Fix Calcite IF DECIMAL return type
Exclude IF's BOOLEAN condition from DECIMAL return-type inference,
fixing INVALID_TYPE for valid DECIMAL branches.
Add regressions for precision/scale, NULL and mixed DECIMAL branches,
plus direct shared query tests for execution on both planners.
Testing: 48 focused IF/DECIMAL query executions passed on Original
and Calcite with fallback disabled, rewrites and codegen on/off.
The baseline reproduced INVALID_TYPE. Tested with a Java class
compile/overlay and existing native binaries, not a full rebuild.
Change-Id: I3101917e02cae76c48c9d9aaf0d2913de00daffb
---
M
java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/CommonOperatorFunctions.java
M
java/calcite-planner/src/test/java/org/apache/impala/calcite/service/CalciteOptimizerTest.java
A testdata/workloads/functional-query/queries/QueryTest/if-decimal.test
M tests/query_test/test_exprs.py
4 files changed, 125 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/04/25004/3
--
To view, visit http://gerrit.cloudera.org:8080/25004
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3101917e02cae76c48c9d9aaf0d2913de00daffb
Gerrit-Change-Number: 25004
Gerrit-PatchSet: 3
Gerrit-Owner: Aleksandr Efimov <[email protected]>
Gerrit-Reviewer: Aleksandr Efimov <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Steve Carlin <[email protected]>
