Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/25006 )
Change subject: IMPALA-15468: Calcite planner: Preserve view validation errors during alias correction ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/25006/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ViewAliasCorrector.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ViewAliasCorrector.java: http://gerrit.cloudera.org:8080/#/c/25006/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ViewAliasCorrector.java@191 PS3, Line 191: SqlNode item = select.getSelectList().get(i); > I'm fine with this change, but curious about it. Just a personal preference The old cast could throw for an unchanged select item, e.g. a SqlIdentifier. Now we only cast items that need alias correction. -- To view, visit http://gerrit.cloudera.org:8080/25006 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib51c4f3bacfdad76dc4dc4a08885b0d5e964e072 Gerrit-Change-Number: 25006 Gerrit-PatchSet: 3 Gerrit-Owner: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Tue, 06 Oct 2026 07:56:59 +0000 Gerrit-HasComments: Yes
