Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10939 )
Change subject: IMPALA-7259: Improve Impala shell performance ...................................................................... Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/10939/8/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/10939/8/shell/impala_shell.py@72 PS8, Line 72: return ''.join(stack.run(sql, 'utf-8')).strip() > I noticed that sqlparse.format() uses an unicode string here: https://githu I don't think it makes a difference and I believe we use utf-8 everywhere in Impala shell. http://gerrit.cloudera.org:8080/#/c/10939/8/tests/shell/test_file_large.sql File tests/shell/test_file_large.sql: PS8: > Trying to boost your LoC count? :) LOL, I will auto-generate it instead. -- To view, visit http://gerrit.cloudera.org:8080/10939 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idac9f3caed7c44846a8c922dbe5ca3bf3b095b81 Gerrit-Change-Number: 10939 Gerrit-PatchSet: 9 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 13 Jul 2018 22:19:02 +0000 Gerrit-HasComments: Yes
