Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/25027 )

Change subject: IMPALA-15490: Calcite planner: Normalize arithmetic HBO keys
......................................................................


Patch Set 1:

(1 comment)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/25027/1/fe/src/main/java/org/apache/impala/planner/ExprCanonicalizer.java
File fe/src/main/java/org/apache/impala/planner/ExprCanonicalizer.java:

http://gerrit.cloudera.org:8080/#/c/25027/1/fe/src/main/java/org/apache/impala/planner/ExprCanonicalizer.java@358
PS1, Line 358:           args.add(CastExpr.createExplicit(new 
TypeDef(expr.getChild(i).getType()), child));
line too long (92 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/25027
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieeab4a08f2f57d1baec7868200195c982544c465
Gerrit-Change-Number: 25027
Gerrit-PatchSet: 1
Gerrit-Owner: Aleksandr Efimov <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Steve Carlin <[email protected]>
Gerrit-Comment-Date: Tue, 06 Oct 2026 14:23:32 +0000
Gerrit-HasComments: Yes

Reply via email to