Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24991 )
Change subject: IMPALA-15461: Look up Iceberg partition specs by id ...................................................................... Patch Set 2: (2 comments) Thanks for the comments! http://gerrit.cloudera.org:8080/#/c/24991/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24991/1//COMMIT_MSG@10 PS1, Line 10: Since Iceberg 1.8.0, : ExpireSnapshots.cleanExpiredMetadata(true) removes unused specs and : can leave e.g. only spec 1. > nit: Done. Reworded to '...multiple partition specs'. http://gerrit.cloudera.org:8080/#/c/24991/1/fe/src/main/java/org/apache/impala/analysis/ShowStatsStmt.java File fe/src/main/java/org/apache/impala/analysis/ShowStatsStmt.java: http://gerrit.cloudera.org:8080/#/c/24991/1/fe/src/main/java/org/apache/impala/analysis/ShowStatsStmt.java@137 PS1, Line 137: IcebergPartitionSpec defaultSpec = feIcebergTable.getDefaultPar > This null check is redundant here, but getDefaultPartitionSpec().hasPartiti Done. -- To view, visit http://gerrit.cloudera.org:8080/24991 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8a0aa3364048a3e7957593ca8f98592b43f2fcd8 Gerrit-Change-Number: 24991 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 07 Oct 2026 09:12:36 +0000 Gerrit-HasComments: Yes
