Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22447 )
Change subject: IMPALA-4017: support ANSI timestamp literal cast ...................................................................... Patch Set 6: (11 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22447/6/fe/src/main/java/org/apache/impala/analysis/TimestampLiteral.java File fe/src/main/java/org/apache/impala/analysis/TimestampLiteral.java: http://gerrit.cloudera.org:8080/#/c/22447/6/fe/src/main/java/org/apache/impala/analysis/TimestampLiteral.java@116 PS6, Line 116: public int hashCode() { line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22447/6/fe/src/main/java/org/apache/impala/analysis/TimestampLiteral.java@117 PS6, Line 117: return Arrays.hashCode(value_); line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22447/6/fe/src/main/java/org/apache/impala/analysis/TimestampLiteral.java@127 PS6, Line 127: public String getStringValue() { line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22447/6/fe/src/main/java/org/apache/impala/analysis/TimestampLiteral.java@128 PS6, Line 128: return strValue_; line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22447/6/fe/src/main/java/org/apache/impala/analysis/TimestampLiteral.java@131 PS6, Line 131: public byte[] getValue() { line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22447/6/fe/src/main/java/org/apache/impala/analysis/TimestampLiteral.java@156 PS6, Line 156: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22447/6/fe/src/main/java/org/apache/impala/analysis/TimestampLiteral.java@162 PS6, Line 162: public Expr clone() { line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22447/6/fe/src/main/java/org/apache/impala/analysis/TimestampLiteral.java@163 PS6, Line 163: return new TimestampLiteral(this); line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22447/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java File fe/src/test/java/org/apache/impala/analysis/ParserTest.java: http://gerrit.cloudera.org:8080/#/c/22447/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@30 PS6, Line 30: import org.apache.impala.analysis.Selectstmt; unused import: org.apache.impala.analysis.Selectstmt http://gerrit.cloudera.org:8080/#/c/22447/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@1524 PS6, Line 1524: SelectStmt stmt = (SelectStmt) Parser.parser("SElECT TIMESTAMP '2010-03-25 12:47:32'"); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/22447/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@1532 PS6, Line 1532: SelectStmt stmt = (SelectStmt) Parser.parser("SElECT TIMESTAMP '2010-03-25 12:55.49.123456'"); line too long (98 > 90) -- To view, visit http://gerrit.cloudera.org:8080/22447 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibcfd219c0a3192b2e2ea9a9363636f6194df8174 Gerrit-Change-Number: 22447 Gerrit-PatchSet: 6 Gerrit-Owner: Anshula Jain <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Comment-Date: Wed, 07 Oct 2026 18:34:43 +0000 Gerrit-HasComments: Yes
