Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24990 )
Change subject: IMPALA-15460: Read VARIANT object fields stored out of name order ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/24990/2/be/src/runtime/variant-value.cc File be/src/runtime/variant-value.cc: http://gerrit.cloudera.org:8080/#/c/24990/2/be/src/runtime/variant-value.cc@333 PS2, Line 333: name is it enough to check 'name', or SPARK-58949 can break the contract the bisect above relies on if one of the checked field_name names have chars above 0xEE, but 'name' doesn't? -- To view, visit http://gerrit.cloudera.org:8080/24990 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ief71d02788a4c830619e6ceaf45ef8eed366411f Gerrit-Change-Number: 24990 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 08 Oct 2026 08:45:31 +0000 Gerrit-HasComments: Yes
