Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/25039 )
Change subject: IMPALA-15493: Coordinator-local DDL execution for Iceberg REST catalogs ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/25039/3/fe/src/main/java/org/apache/impala/catalog/local/MultiMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/MultiMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/25039/3/fe/src/main/java/org/apache/impala/catalog/local/MultiMetaProvider.java@123 PS3, Line 123: if (answer.first) return answer.second; > What if the database exists in more than one catalog? When the table fails In PS4, a cached REST owner survives even when a fresh CatalogD listing contains the table. loadTable() can use CatalogD while DROP, including PURGE, goes to REST. Could we reject this conflict and add a regression test? http://gerrit.cloudera.org:8080/#/c/25039/3/fe/src/main/java/org/apache/impala/catalog/local/MultiMetaProvider.java@125 PS3, Line 125: return null; > With multiple REST catalogs and no CatalogD, DROP TABLE IF EXISTS missing_d The test expects “Database does not exist”, but HadoopCatalog returns false and REST reports “Table does not exist.” Could we fix the expectation and check both single- and multi-catalog cases? http://gerrit.cloudera.org:8080/#/c/25039/3/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/25039/3/fe/src/main/java/org/apache/impala/service/Frontend.java@699 PS3, Line 699: return getCatalogNameForDdl(catalogManager_, stmt.getTable(), stmt.getDb()); > I think we still miss the single-provider case here. If metadata loading th PS4 still misses NoSuchNamespaceException in loadTable(). If the namespace disappears after listing, DROP TABLE IF EXISTS fails during metadata loading. Could we wrap it too and add a test? -- To view, visit http://gerrit.cloudera.org:8080/25039 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I932a211b25ea4e24a607d047c35da186d8922d02 Gerrit-Change-Number: 25039 Gerrit-PatchSet: 3 Gerrit-Owner: Peter Rozsa <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 08 Oct 2026 09:33:49 +0000 Gerrit-HasComments: Yes
