Hello Steve Carlin, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/25009
to look at the new patch set (#4).
Change subject: IMPALA-15469: Fix Calcite outer-join transfers
......................................................................
IMPALA-15469: Fix Calcite outer-join transfers
Use the aggregate result tuple and clause-local join metadata to restore
safe LEFT JOIN value transfer and prevent unsafe RIGHT/FULL JOIN edges.
This also restores the missing INNER JOIN runtime filter on the fact scan.
Keep Analyzer's directional safety checks unchanged.
Add an e2e regression with a LEFT JOIN to an aggregate and a subsequent
INNER JOIN. Check the executed query's fact-scan runtime filter and retain
unmatched keys with NULL aggregate results. Compare Calcite and Original
with planner fallback disabled.
Move the e2e SQL and runtime-filter checks into a QueryTest file.
Set the single-node threshold explicitly for shell reproduction.
Testing:
- The new e2e test fails on the parent because Calcite omits the fact-scan
runtime filter, and passes with the fix.
- Both planners return the expected rows with codegen on and off.
- Full precommit not rerun.
Change-Id: Ib18be8927868fd910530396967d6cee81df6d531
---
M
java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAggRel.java
M
java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaJoinRel.java
A
java/calcite-planner/src/test/java/org/apache/impala/planner/OuterJoinValueTransferTest.java
A
testdata/workloads/functional-query/queries/QueryTest/calcite-outer-join-value-transfer.test
M tests/query_test/test_calcite_planner.py
5 files changed, 332 insertions(+), 20 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/09/25009/4
--
To view, visit http://gerrit.cloudera.org:8080/25009
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib18be8927868fd910530396967d6cee81df6d531
Gerrit-Change-Number: 25009
Gerrit-PatchSet: 4
Gerrit-Owner: Aleksandr Efimov <[email protected]>
Gerrit-Reviewer: Aleksandr Efimov <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Steve Carlin <[email protected]>
