Hello Steve Carlin, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/25024
to look at the new patch set (#2).
Change subject: IMPALA-15486: Fix Calcite DECIMAL scale types
......................................................................
IMPALA-15486: Fix Calcite DECIMAL scale types
Clamp DECIMAL scale to the input scale and zero, and derive precision
from the remaining digits. Add a carry digit only when ROUND/DROUND
reduce scale; use minimum precision 1 for fractional-only truncation.
Leave non-decimal inference unchanged.
Add one shared QueryTest file for Original and Calcite, covering scale
changes, NULLs, negative values and precision boundaries. Reuse its
queries to compare full HS2 result schemas with fallback disabled.
Testing: focused pytest passed with both planners. The shared test
fails on the parent during Calcite type inference.
Full upstream precommit remains unverified.
Change-Id: I8f6e6e2eaa7fe6eeab88b4143ed6b73e65220333
---
M
java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaAdjustScaleFunction.java
A
java/calcite-planner/src/test/java/org/apache/impala/calcite/service/CalciteDecimalScaleTest.java
A
testdata/workloads/functional-query/queries/QueryTest/calcite-decimal-scale.test
M tests/query_test/test_calcite_planner.py
4 files changed, 320 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/25024/2
--
To view, visit http://gerrit.cloudera.org:8080/25024
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8f6e6e2eaa7fe6eeab88b4143ed6b73e65220333
Gerrit-Change-Number: 25024
Gerrit-PatchSet: 2
Gerrit-Owner: Aleksandr Efimov <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Steve Carlin <[email protected]>
