Hello Steve Carlin, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/25026
to look at the new patch set (#2).
Change subject: IMPALA-15488: Fix Calcite integer scale calls
......................................................................
IMPALA-15488: Fix Calcite integer scale calls
Use DOUBLE for one-argument integer calls. For explicit scale, cast
integer operands to their minimum-resolution DECIMAL and clamp the
result scale. Preserve existing FLOAT/DOUBLE and DECIMAL behavior.
Add one shared QueryTest file for Original and Calcite across integer
types and scales, including NULLs, zero and negative values. Reuse its
queries to compare full HS2 result schemas with fallback disabled.
Testing: focused pytest passed with both planners. The shared test
fails on the parent during integer scale planning.
Full upstream precommit remains unverified.
Change-Id: I4d66850c7de4c04bacbac9f1470e313abdc3ea3c
---
M
java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java
M
java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaAdjustScaleFunction.java
A
java/calcite-planner/src/test/java/org/apache/impala/calcite/service/CalciteIntegerScaleTest.java
A
testdata/workloads/functional-query/queries/QueryTest/calcite-integer-scale.test
M tests/query_test/test_calcite_planner.py
5 files changed, 316 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/25026/2
--
To view, visit http://gerrit.cloudera.org:8080/25026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4d66850c7de4c04bacbac9f1470e313abdc3ea3c
Gerrit-Change-Number: 25026
Gerrit-PatchSet: 2
Gerrit-Owner: Aleksandr Efimov <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Steve Carlin <[email protected]>
