Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/10615 )
Change subject: IMPALA-7132: Filter out useless output from run_clang_tidy.sh ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/10615/3/bin/run_clang_tidy.sh File bin/run_clang_tidy.sh: http://gerrit.cloudera.org:8080/#/c/10615/3/bin/run_clang_tidy.sh@57 PS3, Line 57: TMP_STDERR=$(mktemp) When making a temp file, can you rm it on exit? http://tldp.org/LDP/Bash-Beginners-Guide/html/sect_12_02.html trap "rm $TMP_STDERR" EXIT -- To view, visit http://gerrit.cloudera.org:8080/10615 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I63c46a7d57295eba38fac8ab49c7a15d2802df1d Gerrit-Change-Number: 10615 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Comment-Date: Mon, 16 Jul 2018 23:30:52 +0000 Gerrit-HasComments: Yes
