Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10951 )
Change subject: IMPALA-7304: Don't write floating column index until PARQUET-1222 is resolved. ...................................................................... IMPALA-7304: Don't write floating column index until PARQUET-1222 is resolved. Impala master branch can already write the Parquet page index. However, we still don't have a well-defined ordering for floating-point numbers in Parquet, see PARQUET-1222 Currently impala writes the page index with fmax()/fmin() semantics, but it might contradicts the future semantics that will be defined once PARQUET-1222 is resolved. >From this patch Impala won't write the column index for floating-point columns until PARQUET-1222 is resolved and implemented. I updated the python test accordingly. Change-Id: I50aa2e6607de6a8943eb068b8162b0506763078b Reviewed-on: http://gerrit.cloudera.org:8080/10951 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/exec/hdfs-parquet-table-writer.cc M tests/query_test/test_parquet_page_index.py 2 files changed, 11 insertions(+), 0 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/10951 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I50aa2e6607de6a8943eb068b8162b0506763078b Gerrit-Change-Number: 10951 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
