Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10913 )
Change subject: IMPALA-7276. Support CREATE TABLE AS SELECT with LocalCatalog ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/10913/2/fe/src/main/java/org/apache/impala/catalog/Db.java File fe/src/main/java/org/apache/impala/catalog/Db.java: http://gerrit.cloudera.org:8080/#/c/10913/2/fe/src/main/java/org/apache/impala/catalog/Db.java@176 PS2, Line 176: public FeKuduTable createKuduCtasTarget(org.apache.hadoop.hive.metastore.api.Table msTbl, > nit: long line Done http://gerrit.cloudera.org:8080/#/c/10913/2/fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java File fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java: http://gerrit.cloudera.org:8080/#/c/10913/2/fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java@57 PS2, Line 57: import org.apache.sentry.hdfs.service.thrift.SentryHDFSService.get_all_related_paths_result; > sorry, Eclipse went nuts on autocomplete here apparently. Will remove in ne Done http://gerrit.cloudera.org:8080/#/c/10913/2/fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java@211 PS2, Line 211: public TTableDescriptor toThriftDescriptor(int tableId, Set<Long> referencedPartitions) { > nit: long line Done http://gerrit.cloudera.org:8080/#/c/10913/2/fe/src/main/java/org/apache/impala/catalog/local/LocalKuduTable.java File fe/src/main/java/org/apache/impala/catalog/local/LocalKuduTable.java: http://gerrit.cloudera.org:8080/#/c/10913/2/fe/src/main/java/org/apache/impala/catalog/local/LocalKuduTable.java@83 PS2, Line 83: List<KuduPartitionParam> partitionBy = KuduTable.loadPartitionByParams( > nit: this could be one line Done -- To view, visit http://gerrit.cloudera.org:8080/10913 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I93937aed9b76ef6a62b1c588c59c34d3d6831a46 Gerrit-Change-Number: 10913 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Wed, 18 Jul 2018 00:59:42 +0000 Gerrit-HasComments: Yes
