Hello Tianyi Wang, Vuk Ercegovac,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/10974
to review the following change.
Change subject: IMPALA-7311. Allow INSERT on writable partitions even if some
other partition is READ_ONLY
......................................................................
IMPALA-7311. Allow INSERT on writable partitions even if some other partition
is READ_ONLY
This changes the permissions-checking of INSERT so that, if a partition
is specified, we only verify writability of the specific explicit
partition. This allows insertion into a table even if it contains one or
more read-only partitions. This matches the existing behavior of LOAD
DATA.
A regression test is added which failed prior to the fix.
Change-Id: I1dd81100ae73fcabdbfaf679c20cea7dc102cd13
---
M fe/src/main/java/org/apache/impala/analysis/InsertStmt.java
M fe/src/main/java/org/apache/impala/analysis/LoadDataStmt.java
M fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java
M fe/src/main/java/org/apache/impala/catalog/FeFsTable.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java
M tests/metadata/test_hdfs_permissions.py
M tests/query_test/test_insert_behaviour.py
8 files changed, 175 insertions(+), 77 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/74/10974/1
--
To view, visit http://gerrit.cloudera.org:8080/10974
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1dd81100ae73fcabdbfaf679c20cea7dc102cd13
Gerrit-Change-Number: 10974
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Tianyi Wang <[email protected]>
Gerrit-Reviewer: Vuk Ercegovac <[email protected]>
