Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9751 )
Change subject: [experimental] Clang Tidy Diff trial balloon ...................................................................... Patch Set 2: Here are my thoughts on this CR: 1. I'm going to file a JIRA about clang tidy diff. Even if we don't pursue this, there should be a record for later. I will incorporate that JIRA on this CR. 2. Clang tidy diff is dramatically faster than run_clang_tidy.sh, but it is also not 100% correct. There are code changes that can introduce clang tidy issues in code that hasn't changed. Unless we are comfortable with that, clang tidy diff won't replace run_clang_tidy.sh. 3. For automated jobs (like clang-tidy-ub1604 and whatever happens for IMPALA-7317), speed only matters so much. 4. I think some improvements to run_clang_tidy.sh to be able to run clang tidy on a list of files would cut down on the cost to run locally. -- To view, visit http://gerrit.cloudera.org:8080/9751 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie2fb6a13400367fd3d12a4738bbb2dfc944466a7 Gerrit-Change-Number: 9751 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 18 Jul 2018 22:19:03 +0000 Gerrit-HasComments: No
