Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10893 )
Change subject: IMPALA-6677: [DOCS] Document the next_day function ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/10893/4/docs/topics/impala_datetime_functions.xml File docs/topics/impala_datetime_functions.xml: http://gerrit.cloudera.org:8080/#/c/10893/4/docs/topics/impala_datetime_functions.xml@1941 PS4, Line 1941: SELECT NEXT_DAY I've followed a little bit the discussion about moving towards this style. However, I'd prefer that we retain file-level consistency, then move to the new style at the file granularity. I'm concerned that an inconsistent style for a given file will be worse than a consistent style, even it we're moving away from it. This file looks like it uses lower-case for both keywords and functions. -- To view, visit http://gerrit.cloudera.org:8080/10893 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2dacc86ff69a1016b1863d9db66dd29fd832b715 Gerrit-Change-Number: 10893 Gerrit-PatchSet: 4 Gerrit-Owner: Alex Rodoni <arod...@cloudera.com> Gerrit-Reviewer: Alex Rodoni <arod...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Thu, 19 Jul 2018 23:58:00 +0000 Gerrit-HasComments: Yes
