Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10979 )
Change subject: IMPALA-6299: Modify IRBuilder to use LLVM's CPU features ...................................................................... Patch Set 2: (3 comments) No worries about the rebase, it happens sometimes. http://gerrit.cloudera.org:8080/#/c/10979/2/be/src/codegen/llvm-codegen-test.cc File be/src/codegen/llvm-codegen-test.cc: http://gerrit.cloudera.org:8080/#/c/10979/2/be/src/codegen/llvm-codegen-test.cc@467 PS2, Line 467: CpuInfo::EnableFeature(CpuInfo::SSE4_2, false); > Yes, because `expected_hash` is computed using the `HashUtil::Hash` functio Thanks for explaining. Might be worth leaving a brief comment explaining this. http://gerrit.cloudera.org:8080/#/c/10979/2/be/src/codegen/llvm-codegen.h File be/src/codegen/llvm-codegen.h: http://gerrit.cloudera.org:8080/#/c/10979/2/be/src/codegen/llvm-codegen.h@737 PS2, Line 737: current_cpu_attrs_ Thanks for the explanation. I agree that we should be defensive. Maybe all this needs is a slight clarifying comment about when the contents of the maps may change? > The other option I can think of is trying to figure out from the context if > this is an impalad instance or a test call. We have TestInfo::is_test() - you could add a DCHECK. http://gerrit.cloudera.org:8080/#/c/10979/2/be/src/util/bit-util-test.cc File be/src/util/bit-util-test.cc: http://gerrit.cloudera.org:8080/#/c/10979/2/be/src/util/bit-util-test.cc@325 PS2, Line 325: const int64_t CPU_INFO_FLAG = CpuInfo::SSSE3; > I had to change it because I moved the declaration of CpuInfo::SSSE3 to cpu Gotcha, didn't think of that -- To view, visit http://gerrit.cloudera.org:8080/10979 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifece8949c143146d2a1b38d72d21c2d733bed90f Gerrit-Change-Number: 10979 Gerrit-PatchSet: 2 Gerrit-Owner: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 20 Jul 2018 18:28:29 +0000 Gerrit-HasComments: Yes
