Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10792 )
Change subject: IMPALA-3040: Remove cache directives if a partition is dropped externally ...................................................................... Patch Set 9: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/10792/8/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/10792/8/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@1375 PS8, Line 1375: Set<String> msPartitionNames = Sets.newHashSet(); : msPartitionNames.addAll(client.listPartitionNames(db_.getName(), name_, (short) -1)); : // Names of loaded partitions in this table > I changed the definition of it instead of removing. We have to drop the par nice catch. http://gerrit.cloudera.org:8080/#/c/10792/9/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/10792/9/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@1414 PS9, Line 1414: dropPartitions(dirtyPartitions, false); Add a comment that dirtyPartitions are reloaded and hence cachedirectives are not dropped. Easier for those reading the code to understand. -- To view, visit http://gerrit.cloudera.org:8080/10792 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id7701a499405e961456adea63f3592b43bd69170 Gerrit-Change-Number: 10792 Gerrit-PatchSet: 9 Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Comment-Date: Mon, 23 Jul 2018 22:38:47 +0000 Gerrit-HasComments: Yes
