Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10979 )
Change subject: IMPALA-6299: Use LlvmCodeGen's internal list of white-listed CPU attributes for handcrafting IRs ...................................................................... IMPALA-6299: Use LlvmCodeGen's internal list of white-listed CPU attributes for handcrafting IRs Previously, the IRBuilder of the LlvmCodeGen class used CpuInfo's list of enabled features to determine the validity of certain instructions to emit intrinsics. It did not consider the whitelist which passed while initializing the LlvmCodeGen class. Now, the IRBuilder inspects its own CPU attributes before emitting instruction. This change also adds functionality to modify the CPU attributes of the LlvmCodeGen class for testing. Testing: Verified that the current tests which use and modify CpuInfo produce expected results. Change-Id: Ifece8949c143146d2a1b38d72d21c2d733bed90f Reviewed-on: http://gerrit.cloudera.org:8080/10979 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/benchmarks/bloom-filter-benchmark.cc M be/src/codegen/llvm-codegen-test.cc M be/src/codegen/llvm-codegen.cc M be/src/codegen/llvm-codegen.h M be/src/exec/filter-context.cc M be/src/util/cpu-info.cc 6 files changed, 95 insertions(+), 29 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/10979 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ifece8949c143146d2a1b38d72d21c2d733bed90f Gerrit-Change-Number: 10979 Gerrit-PatchSet: 8 Gerrit-Owner: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
