Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/11007 )
Change subject: IMPALA-7333: remove MarkNeedsDeepCopy() in aggs and joins ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/11007/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11007/4//COMMIT_MSG@7 PS4, Line 7: joins Does this patch address joins? http://gerrit.cloudera.org:8080/#/c/11007/4/be/src/runtime/buffered-tuple-stream-test.cc File be/src/runtime/buffered-tuple-stream-test.cc: http://gerrit.cloudera.org:8080/#/c/11007/4/be/src/runtime/buffered-tuple-stream-test.cc@678 PS4, Line 678: // Note: this should really be 0, but the BufferedTupleStream returns eos before : // attaching the last buffer, rather than after, so the last block isn't deleted : // until the stream is closed. Is this comment still accurate? It is 0 now -- To view, visit http://gerrit.cloudera.org:8080/11007 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I91ac53bacc00df4726c015a30ba5a2026aa4b5f5 Gerrit-Change-Number: 11007 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 24 Jul 2018 22:53:31 +0000 Gerrit-HasComments: Yes
