Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11045 )
Change subject: IMPALA-6335. Allow most shell tests to run in parallel ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/11045/2/tests/custom_cluster/test_shell_interactive_reconnect.py File tests/custom_cluster/test_shell_interactive_reconnect.py: http://gerrit.cloudera.org:8080/#/c/11045/2/tests/custom_cluster/test_shell_interactive_reconnect.py@35 PS2, Line 35: p = ImpalaShell("--history_file=/dev/null") > Wouldn't it be better to put this into setup/teardown, so that it cannot be Will do http://gerrit.cloudera.org:8080/#/c/11045/2/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/11045/2/tests/shell/test_shell_interactive.py@51 PS2, Line 51: self.history_file = tempfile.mktemp() > I would prefer to set IMPALA_HISTFILE to /dev/null by default and use Named will do -- To view, visit http://gerrit.cloudera.org:8080/11045 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1da5739276e63a50590dfcb2b050703f8e35fec7 Gerrit-Change-Number: 11045 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 25 Jul 2018 16:48:52 +0000 Gerrit-HasComments: Yes
