Alex Rodoni has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11043 )

Change subject: IMPALA-7218: [DOCS] Support column list in ALTER VIEW
......................................................................


Patch Set 3:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/11043/3/docs/topics/impala_alter_view.xml
File docs/topics/impala_alter_view.xml:

http://gerrit.cloudera.org:8080/#/c/11043/3/docs/topics/impala_alter_view.xml@82
PS3, Line 82: c3
> Please remove this. Since the select statement has two columns (x, s), the
Done


http://gerrit.cloudera.org:8080/#/c/11043/3/docs/topics/impala_alter_view.xml@105
PS3, Line 105:
> Nit: Please remove the new line.
Done


http://gerrit.cloudera.org:8080/#/c/11043/3/docs/topics/impala_alter_view.xml@118
PS3, Line 118:
> Nit: Please remove the new line.
Actually, the new lines will be back. The new lines are put my the 
xmlformatter. A new line is a recommended format between tags.



--
To view, visit http://gerrit.cloudera.org:8080/11043
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19e5cf97302a46738fd832344415fb7ad4ca0e41
Gerrit-Change-Number: 11043
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <[email protected]>
Gerrit-Reviewer: Alex Rodoni <[email protected]>
Gerrit-Reviewer: Fredy Wijaya <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Pooja Nilangekar <[email protected]>
Gerrit-Comment-Date: Wed, 25 Jul 2018 19:35:34 +0000
Gerrit-HasComments: Yes

Reply via email to