Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11048 )
Change subject: IMPALA-7324: remove MarkNeedsDeepCopy() from sorter ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11048/1/be/src/runtime/row-batch.h File be/src/runtime/row-batch.h: http://gerrit.cloudera.org:8080/#/c/11048/1/be/src/runtime/row-batch.h@299 PS1, Line 299: flush > I would prefer a different name like flush_mode(). flush() suggests that ca Good point. http://gerrit.cloudera.org:8080/#/c/11048/1/be/src/runtime/sorter.cc File be/src/runtime/sorter.cc: http://gerrit.cloudera.org:8080/#/c/11048/1/be/src/runtime/sorter.cc@974 PS1, Line 974: var_len_pages_[var_len_pages_index_].ExtractBuffer(sorter_->buffer_pool_client_); > nit: long line Done -- To view, visit http://gerrit.cloudera.org:8080/11048 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If86f038f1f6ca81ad5c9d40af1b7ea6115144ffc Gerrit-Change-Number: 11048 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 26 Jul 2018 23:19:20 +0000 Gerrit-HasComments: Yes
