Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11064 )
Change subject: IMPALA-7362: Add query option to set timezone ...................................................................... Patch Set 2: (2 comments) The future of this change in under discussion right now - there is an ANSI SQL command "SET TIME ZONE", and it would be nice to support it in Impala, but it expects different input than the query option I implemented here. http://gerrit.cloudera.org:8080/#/c/11064/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11064/2//COMMIT_MSG@9 PS2, Line 9: This change adds a new query option "timezone" which > Yeah I kind of like the shorter name "timezone" upon further reflection. It turned out that MySQL uses "set time_zone=tzname" with similar semantics, so I think I will switch to that name. http://gerrit.cloudera.org:8080/#/c/11064/2/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: http://gerrit.cloudera.org:8080/#/c/11064/2/tests/shell/test_shell_commandline.py@706 PS2, Line 706: result_set = run_impala_shell_cmd('-q "set;"') > Can you also add a test to tests/metadata/test_set.py that exercises the se Done -- To view, visit http://gerrit.cloudera.org:8080/11064 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I73de86eff096e1c581d3b56a0d9330d686f77272 Gerrit-Change-Number: 11064 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Mon, 30 Jul 2018 15:16:31 +0000 Gerrit-HasComments: Yes
