Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10999 )
Change subject: IMPALA-7329: Blacklist CDH Maven snapshots repository ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Thanks. This looks fine to me. Did you confirm with mvn -X or something what repos do and don't get talked to? http://gerrit.cloudera.org:8080/#/c/10999/3/impala-parent/pom.xml File impala-parent/pom.xml: http://gerrit.cloudera.org:8080/#/c/10999/3/impala-parent/pom.xml@73 PS3, Line 73: <repository> In this case, please move some of your commit message into a <!-- comment --> here. It's not obvious that lines 78 and 81 are doing blacklisting here, so let's be pedantic and talk about it. -- To view, visit http://gerrit.cloudera.org:8080/10999 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id945bc2769f92f3df3bb4f617b00db77a6502ff3 Gerrit-Change-Number: 10999 Gerrit-PatchSet: 3 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Comment-Date: Mon, 30 Jul 2018 17:25:41 +0000 Gerrit-HasComments: Yes
