Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11007 )
Change subject: IMPALA-7333: remove MarkNeedsDeepCopy() in agg and BTS ...................................................................... Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/11007/11/be/src/runtime/buffered-tuple-stream-test.cc File be/src/runtime/buffered-tuple-stream-test.cc: http://gerrit.cloudera.org:8080/#/c/11007/11/be/src/runtime/buffered-tuple-stream-test.cc@961 PS11, Line 961: EXPECT_EQ(*static_cast<int*>(in_row->GetTuple(0)->GetSlot(slot_offset)), > optional: Maybe a GetIntSlot() function could be added to Tuple to avoid ca Done -- To view, visit http://gerrit.cloudera.org:8080/11007 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I91ac53bacc00df4726c015a30ba5a2026aa4b5f5 Gerrit-Change-Number: 11007 Gerrit-PatchSet: 11 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 30 Jul 2018 17:28:15 +0000 Gerrit-HasComments: Yes
