Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10998 )
Change subject: IMPALA-6857: Add Jvm pause/GC Monitor utility and expose JMX metrics ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/10998/5/be/src/util/default-path-handlers.cc File be/src/util/default-path-handlers.cc: http://gerrit.cloudera.org:8080/#/c/10998/5/be/src/util/default-path-handlers.cc@243 PS5, Line 243: webserver->RegisterUrlCallback("/jmx", "raw_text_pre.tmpl", JmxHandler); > I still don't see it in Gerrit. It is not needed. PS6 uses common-pre.tmpl https://gerrit.cloudera.org/#/c/10998/6/be/src/util/default-path-handlers.cc Users wouldn't add ?raw. They just do /jmx which is nicely formatted in common-pre.tmpl rather than plain text content-type. common-pre also has a header which helps navigate back. ?raw is only for tools which just want the TEXT version without HTML stuff. http://gerrit.cloudera.org:8080/#/c/10998/6/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/10998/6/tests/webserver/test_web_pages.py@72 PS6, Line 72: response = requests.get(input_url) > that's a good point. If the content-type is appropriate, then I'll get nice ?raw sets the plain content-type. Like I mentioned in the other comment, without ?raw, it is rendered in a common-pre tmpl that lets user navigate back to other places (since it has a header with a list of end points). Anyway if you prefer ?raw to be the default behavior, lemme know. -- To view, visit http://gerrit.cloudera.org:8080/10998 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I30d897b7e063846ad6d8f88243e2c04264da0341 Gerrit-Change-Number: 10998 Gerrit-PatchSet: 5 Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Mon, 30 Jul 2018 23:45:24 +0000 Gerrit-HasComments: Yes
