Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11045 )

Change subject: IMPALA-6335. Allow most shell tests to run in parallel
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11045/5/tests/shell/test_shell_interactive.py
File tests/shell/test_shell_interactive.py:

http://gerrit.cloudera.org:8080/#/c/11045/5/tests/shell/test_shell_interactive.py@49
PS5, Line 49: def tmp_history_file(request):
> Hmm I'll take a look
So we do include the patchset number: 
https://github.com/apache/impala/blob/master/bin/jenkins/critique-gerrit-review.py#L120

I looked at the jenkins job and it looks like the version running against 
patchset 5 (a50d9842) produced those warnings incorrectly, so I'm going to look 
at debugging that. Seems like an issue with somehow running flake8 on the wrong 
commit.



--
To view, visit http://gerrit.cloudera.org:8080/11045
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1da5739276e63a50590dfcb2b050703f8e35fec7
Gerrit-Change-Number: 11045
Gerrit-PatchSet: 5
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Fredy Wijaya <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Pooja Nilangekar <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-Comment-Date: Tue, 31 Jul 2018 16:42:24 +0000
Gerrit-HasComments: Yes

Reply via email to